[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

r21936 is damn suspicious

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 05 Sep 2011 16:37:24 +0400

Hey.

May I wonder why r21936 was committed?

Currently it uses raw pointers and this is not exception-safe. Also in TortoiseIDiff.cpp if control flows through "return (int) msg.wParam;" the window object is not deleted.

Thank you.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2835608

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-09-05 14:37:29 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.