[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch: reducing amount of duplicate code

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 01 Sep 2009 09:14:50 +0400

Hey.

Here's a patch for reducing code duplication. Not tested - needs review.

Also (prior to the patch) in OnCaretLeft() and OnCaretRight() first follows EnsureCaretVisible(), then UpdateCaret(), and in OnCaretUp() and OnCaretDown() the above two calls are in reverse order. Is this reverse order ever needed? If not, onCaretWordLeftRight() method could be renamed into onCaretMove() and further reused.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2389648

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-09-01 07:30:10 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.