Re: Patch: reducing amount of duplicate code

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 08 Sep 2009 10:15:35 +0400

In r17132 a new member variable is introduced in CFormatMessageWrapper. Its interpretation is misleading - it's not HRESULT and therefore should not be used with S_ constants. I also suspect that it is misused - according to MSDN if FormatMessage() succeeds it returns the number of characters retrieved. It could be 14 for example. Then "result" is 14 after such call. operator bool() will compare "14" with "S_OK" (which is 0) and will return "false".

Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2392250

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

application/octet-stream attachment: Patch-MisintepretationOfFormatMessageResult.patch

Received on 2009-09-08 09:02:30 CEST

This message: [ Message body ]
Next message: Joel Low: "RE: Error when running x64 nightly installer"
Previous message: Gunnar Dalsnes: "patch: misc tsvncache work"
In reply to: Dmitry: "Patch: reducing amount of duplicate code"
Next in thread: Stefan Fuhrmann: "Re: Patch: reducing amount of duplicate code"
Reply: Stefan Fuhrmann: "Re: Patch: reducing amount of duplicate code"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]