Re: Handiling of ra_local URL for UNC path

Kazutoshi Satoda wrote:

>> While that form works for non-UNC paths, it is *not* the default form.
>> All Subversion APIs return the form file:/// when asked for URLs.
>
> What API returns the URL for a specific local (including UNC) path?
> I couldn't find such a function in svn_client or svn_ra.

svn_client_info, and all svn_wc_* functions where the working copy was
checked out with the old format.

> I found svn_ra_local__split_URL() in
> subversion/libsvn_ra_local/ra_local.h. The URL to local-path conversion
> is done in this function. But this is not a public API and also the
> result seems to be not visible from client.
>
> In that function, I can see a comment that is saying the form
> "file:///\hostname/path" is supported for compatibility with old
> working copies.

In know that. But there's a bug which for certain functions *requires*
the 'old' format (file:///\hostname/path), where the 'new' format simply
doesn't work.

>>> I made the attached patch by simple grep for "file://". I'm sorry
> (snip)
>> every feature. Sorry, but a simple grep replace just doesn't work.
>
> I made the actual changes by hand, not by simple replace. I did grep
> only to find the points to see. But never mind if the patch really
> breaks features. I'm sorry about that.

Well, I could see that some functions you changed also changed their
behavior completely (not just the URL handling). Also some changes in
comments really looked like search/replace - they didn't make any sense
anymore after your change. So I wouldn't take the risk of applying such
a patch.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net