[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Reduce disk access when browsing non-versioned directories

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-02-27 21:37:37 CET

Tobias Schäfer wrote:

>> if (m_entriesFileTime == entriesFilePath.GetLastWriteTime() &&
>> entriesFilePath.Exists() && ...)
>
> Do you suggest the following?
>
> if (m_entriesFileTime == entriesFilePath.GetLastWriteTime() &&
> entriesFilePath.Exists() &&
> m_propsFileTime == propsDirPath.GetLastWriteTime())
>
> This changes the behaviour because if .svn\entries does not exist the whole
> expression will evaluate to "false".
>
> What do you think about this patch?

That patch is good. Just one tiny little thing: I think we should
enclose the '==' conditions in brackets.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Feb 27 21:37:57 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.