[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Reduce disk access when browsing non-versioned directories

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2007-02-27 21:28:12 CET

On Tuesday 27 February 2007 19:59, Stefan Küng wrote:

> We really need to check both, but of course if entriesFilePath does not
> exist, *then* we can avoid checking the filetime of propsDirPath.

ok, I now understand that both are required.

> So, I suggest this:
>
> if (m_entriesFileTime == entriesFilePath.GetLastWriteTime() &&
> entriesFilePath.Exists() && ...)

Do you suggest the following?

if (m_entriesFileTime == entriesFilePath.GetLastWriteTime() &&
entriesFilePath.Exists() &&
m_propsFileTime == propsDirPath.GetLastWriteTime())

This changes the behaviour because if .svn\entries does not exist the whole
expression will evaluate to "false".

What do you think about this patch?

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Tue Feb 27 21:31:02 2007

This is an archived mail posted to the TortoiseSVN Dev mailing list.