[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Get lock without needs-lock message

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-05-16 22:13:42 CEST

Sorry for the very late answer to this - I had to many mails in my inbox
and this one just got lost somehow...

Tobias Schäfer wrote:

> Instead of checking if the property svn:needs-lock is set in the working
> copy we need to check if it is set in BASE or maybe even in HEAD.

checking it in BASE is useless: if it isn't set in WC, then having it
set in BASE means the user has *removed* the property. Checking in HEAD
means checking the repo, which we don't do in the commit dialog.

> Do we need to rephrase the warning message to take this change into account?
> It currently reads:
> "Getting a lock for files without the 'svn:needs-lock' property will
> <b>not</b> prevent others from editing them in their working copies.\nTo
> enable strict locking please add the 'svn:needs-lock' property to all files
> that need locking, and commit those files.\nEach file will have the
> file-system read-only flag set, and getting a lock will make the file
> writable.\nNote that other users will need to update their working copies
> before they see the files as read-only."
>
> It clearly states that the property needs to be committed. I think that is
> enough.

That is ok with me. The message is clear now.

> Stefan, could you please have a look at the patch. Is there no easier way of
> implementing it?

You're reading the property for *every file*. That will increase the
time until the commit dialog is ready a lot.
But since we're dealing here with Subversion 1.4, please have a look at
the new status information: the svn:needs-lock property is now stored in
the .svn\entries file, which means you can get it from the status
struct. That will only require a few more CPU cycles, but not any file
access and therefore will be *much* faster.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue May 16 22:14:04 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.