Re: Get lock without needs-lock message

Stefan Küng wrote:
> Tobias Schäfer wrote:
>
>> Instead of checking if the property svn:needs-lock is set in the
>> working copy we need to check if it is set in BASE or maybe even in HEAD.
>
> checking it in BASE is useless: if it isn't set in WC, then having it
> set in BASE means the user has *removed* the property. Checking in HEAD
> means checking the repo, which we don't do in the commit dialog.

Not useless. If it doesn't exist in BASE then it is not in the
repository unless someone else has already added it. If it is not too
costly, the warning should appear if needs-lock is missing from the WC
*or* missing from BASE. But I guess the 1.4 status info doesn't give us
both?

I agree that we don't really want to check the repo, unless there is
another button to do that, and I really don't think it's worth the effort.

BTW, this is the GetLock dialog, not Commit, but the processing will be
much the same.

Simon

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org