[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ra_serf and APR_EAGAIN handling

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: Tue, 12 Jun 2012 15:08:00 +0200

On Tue, Jun 12, 2012 at 2:38 PM, Lieven Govaerts <lgo_at_mobsol.be> wrote:
> Attached patch shows what I suggest. The case you probably encounter
> is when the response is handled by handle_server_error.
> This is untested, I don't have a Windows setup ready and didn't
> install my build tools yet after upgrade to OS X S.L.

After a conversation in IRC, we're going to test this one out... =) -- justin

Index: subversion/libsvn_ra_serf/util.c
===================================================================
--- subversion/libsvn_ra_serf/util.c (revision 1349303)
+++ subversion/libsvn_ra_serf/util.c (working copy)
@@ -1895,6 +1895,13 @@ handle_response(serf_request_t *request,
          svn_error_t will get unwrapped, and that APR_EAGAIN will be
          returned to serf. We'll get called later, when more network data
          is available. */
+ if (err && APR_STATUS_IS_EAGAIN(err->apr_err))
+ {
+ *serf_status = err->apr_err;
+ svn_error_clear(err);
+ return SVN_NO_ERROR;
+ }
+
       if (!err || !APR_STATUS_IS_EOF(err->apr_err))
         return svn_error_trace(err);
Received on 2012-06-12 15:08:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.