[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1330455 - /subversion/trunk/subversion/libsvn_repos/hooks.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 25 Apr 2012 14:58:47 -0400

On Apr 25, 2012 2:10 PM, <stsp_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr 25 18:10:15
2012
> @@ -232,25 +232,19 @@ run_hook_cmd(svn_string_t **result,
> env_from_env_hash(hooks_env, pool, pool),
> FALSE, FALSE, stdin_handle, result != NULL,
> null_handle, TRUE, NULL, pool);
> -
> - if (err)
> - {
> - /* CMD_PROC is not safe to use. Bail. */
> - return svn_error_createf
> - (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to start '%s'
hook"), cmd);

You lost this potential error return. ??
Received on 2012-04-25 20:59:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.