Re: svn commit: r1330455 - /subversion/trunk/subversion/libsvn_repos/hooks.c

Greg Stein <gstein_at_gmail.com> writes:

> On Apr 25, 2012 2:10 PM, <stsp_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_repos/hooks.c Wed Apr 25 18:10:15
> 2012
>> @@ -232,25 +232,19 @@ run_hook_cmd(svn_string_t **result,
>> env_from_env_hash(hooks_env, pool, pool),
>> FALSE, FALSE, stdin_handle, result != NULL,
>> null_handle, TRUE, NULL, pool);
>> -
>> - if (err)
>> - {
>> - /* CMD_PROC is not safe to use. Bail. */
>> - return svn_error_createf
>> - (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to start '%s'
> hook"), cmd);
>
> You lost this potential error return. ??

Yes, we discussed it on IRC and it has been restored.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com