[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

From: Kannan <kannanr_at_collab.net>
Date: Fri, 04 Dec 2009 23:29:38 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
> On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote:
>> What's the benefit of this change?

  If not in many places, the variable is used only in one such instance
  which could very well be replaced with the method. Sort of minor
  tweak.

> Speaking for myself... it's clearly just a tiny code improvement. +1.
>
> I thin it is also more consistent with the way such checks are done in
> other svn_client functions.

Thank you.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSxlOCXlTqcY7ytmIAQJdFwf/REPo5L3mXiZDscBMDOzlQm3FtrsmwSaM
hCS/mIGpIqmc8rP9f6jawGg302Mq3M5dHU4eLIZC7db2DSc/blwyvagQpwYHUgIb
yYno4JT//EQ2olqnH5gVbYZhnLF2krgoGNAao92UNHkqH8Ny28m7t/YFJDiEa5iP
TKC9iWh905Re0QTYJ6cU9by8nGo54zFR+ep/4wFMEmRTdmuWPqDeNOfqMoFGPcR8
ozCq8Fo3XbPdto+idDcIzrrSiDanViy9qcNH81aygPOdjLJHfcu+VWugOmJcxQm2
a2akgMZCbiOLKa/JSD0eKqzAHueOpelwfKc9JXNZ994d+gD90P2bvg==
=EqHu
-----END PGP SIGNATURE-----
Received on 2009-12-04 19:02:15 CET

This is an archived mail posted to the Subversion Dev mailing list.