[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Substitute `svn_path_is_url()' for a bool variable in log.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sat, 05 Dec 2009 01:03:21 +0000

Kannan wrote:
> Julian Foad wrote:
> > On Fri, 2009-12-04 at 19:49 +0200, Daniel Shahaf wrote:
> >> What's the benefit of this change?
>
> If not in many places, the variable is used only in one such instance
> which could very well be replaced with the method. Sort of minor
> tweak.
>
> > Speaking for myself... it's clearly just a tiny code improvement. +1.
> >
> > I thin it is also more consistent with the way such checks are done in
> > other svn_client functions.
>
> Thank you.

Committed revision 887476.

- Julian
Received on 2009-12-05 02:03:55 CET

This is an archived mail posted to the Subversion Dev mailing list.