[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 9 Nov 2009 08:51:28 -0500

On Sun, Nov 8, 2009 at 05:17, Stefan Sperling <stsp_at_elego.de> wrote:
> On Sun, Nov 08, 2009 at 07:30:36AM +0100, Branko Cibej wrote:
>> Verdict: -1, please revert this change.
>
> +1 on revert, and simply removing #include <svn_debug.h> from
> svn_types.h and requiring people who use SVN_DBG to include svn_debug.h
> manually.

I put the include into svn_types.h to make our lives easier. Without
that, then we'll end up with svn_debug.h scattered around (as noted by
Arfrever's removal of them).

There should be NO PROBLEM including a private header from a public
one, if that inclusion only happens *for us*.

And can I just say: -1 also on all these changes. This is a pretty
crappy "solution" to whatever the original problem might have been.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415784
Received on 2009-11-09 14:51:46 CET

This is an archived mail posted to the Subversion Dev mailing list.