Re: svn commit: r40417 - in trunk: . subversion/include subversion/include/private subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc

Greg Stein wrote:
> On Sun, Nov 8, 2009 at 05:17, Stefan Sperling <stsp_at_elego.de> wrote:
>
>> On Sun, Nov 08, 2009 at 07:30:36AM +0100, Branko Cibej wrote:
>>
>>> Verdict: -1, please revert this change.
>>>
>> +1 on revert, and simply removing #include <svn_debug.h> from
>> svn_types.h and requiring people who use SVN_DBG to include svn_debug.h
>> manually.
>>
>
> I put the include into svn_types.h to make our lives easier. Without
> that, then we'll end up with svn_debug.h scattered around (as noted by
> Arfrever's removal of them).
>
> There should be NO PROBLEM including a private header from a public
> one, if that inclusion only happens *for us*.
>

Well ... Yeah, I guess, sure, as long as no-one who builds tools on top
of an installed Subversion #defines SVN_DEBUG in their build. Now I know
of no good reason to do such a thing; but it could happen.

So in the end, its a choice between telling said user in an ugly way
that she should leave off defining SVN_DEBUG (file not found:
private/svn_debug.h), or just silently ignoring that. Or generating
svn_types.h.

Frankly at this point I can't be bothered to think things through enough
to care; as long as the "fix" got reverted.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415789
Received on 2009-11-09 15:01:57 CET