[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26732 - in trunk/subversion: libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn tests/cmdline tests/cmdline/svntest

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-09-22 01:58:36 CEST

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

epg@tigris.org wrote:
> Author: epg
> Date: Fri Sep 21 13:07:44 2007
> New Revision: 26732
>
> Log:
> r26426 introduced a final sentinel call in ra-{neon,serf,svn} but not
> ra-local, resulting in an extra invalid </logentry> in log --xml output.
> Callers already know the log is finished because control returns from
> svn_ra_get_log2, so just drop this extra receiver call.
>
> * subversion/libsvn_ra_neon/log.c
> (log_end_element): Don't follow last log entry with one more
> SVN_INVALID_REVNUM call to the receiver.
>
> * subversion/libsvn_ra_serf/log.c
> (end_log): Don't follow last log entry with one more
> SVN_INVALID_REVNUM call to the receiver.
>
> * subversion/libsvn_ra_svn/client.c
> (ra_svn_log): Don't follow last log entry with one more
> SVN_INVALID_REVNUM call to the receiver.
>
> * subversion/tests/cmdline/svntest/actions.py
> (LogEntry, LogParser): Add utility classes for testing and parsing svn
> log --xml output.
> (run_and_verify_log_xml): Add function to test svn log --xml output.
>
> * subversion/tests/cmdline/log_tests.py
> (merge_sensitive_log_added_path): Test with run_and_verify_log_xml too.

We should probably update the documentation in svn_types.h and JavaHL to
mention that the primary set of messages won't be followed by a
SVN_INVALID_REVNUM invocation.

- -Hyrum
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9FqXCwOubk4kUXwRAv2KAJ41CCsW6+wE2pEudrcW+sql+HK9BwCguD+f
MVaFuCD1mqwFP2ajpBGOc4U=
=Ckax
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 22 01:58:47 2007

This is an archived mail posted to the Subversion Dev mailing list.