[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav && out-of-memory in Neon

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-12-12 16:07:58 CET

On 12/11/06, Daniel Rall <dlr@collab.net> wrote:
> On Sun, 10 Dec 2006, Erik Huelsmann wrote:
>
> > Working on the ra_dav-refactoring branch, I noticed that sometimes
> > succesfull creation of Neon resources is explicitly checked: Most of
> > the time, for example, is the return value from ne_request_create()
> > checked for non-nullity.
> >
> > Checking the neon sources, all Neon ever does in its constructors is
> > allocate memory and initialize it. When we fail to allocate memory in
> > our libraries, we just abort().
> >
> > I'd like to replace these explicit checks (and the subsequent -memory
> > allocating- creation of an error) with abort calls in the functions we
> > wrapped around these Neon constructors. Especially since at other
> > times, we don't check for nullity at all (for example when creating
> > lock structures...).
> >
> > So, anybody with objections?
>
> Nope, this sounds good, especially if it's consistent with
> Subversion's usual pattern.

Done.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 12 16:08:45 2006

This is an archived mail posted to the Subversion Dev mailing list.