[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22656 - in branches/multiple-moves/subversion: include libsvn_client

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2006-12-12 15:14:07 CET

Daniel Rall wrote:
> On Mon, 11 Dec 2006, hwright@tigris.org wrote:
> ...
>> @@ -1486,6 +1490,10 @@
>> const svn_opt_revision_t src_revision
>> = { svn_opt_revision_unspecified, { 0 } };
>> svn_error_t *err;
>> +
>> + if ( (src_paths->nelts > 1) && ! (move_as_child) )
>> + return svn_error_create(SVN_ERR_CLIENT_MULTIPLE_SOURCES_DISALLOWED,
>> + NULL, NULL);
> ...
>
> In the Subversion sources, I've noticed these types of conditionals
> typically written without the additional whitespace. Additionally,
> the parens around both the "greater than" and *_as_child checks are
> extraneous. This would be more consistent:
>
> if ((src_paths->nelts) > 1 && !copy_as_child)
>
> This is my personal preference:
>
> if (src_paths->nelts > 1 && !copy_as_child)

Heh, that's actually my preference as well. I guess I got a little
carried away with the HACKING comment to "be generous with parentheses
even when you're sure about the operator precedence". :)

Formatting updated in r22659.

-Hyrum

Received on Tue Dec 12 15:14:30 2006

This is an archived mail posted to the Subversion Dev mailing list.