[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improving support for copy and move

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-05-16 22:51:59 CEST

"Ivan Zhakov" <chemodax@gmail.com> wrote on 05/16/2006 02:12:58 PM:

> On 5/16/06, Mark Phippard <markp@softlanding.com> wrote:
> > "Ivan Zhakov" <chemodax@gmail.com> wrote on 05/16/2006 02:02:06 PM:
> >
> > > On 5/16/06, Mark Phippard <markp@softlanding.com> wrote:
> > > > This is an existing issue for which Ivan Zhakov has already
written a
> > > > patch. I brought this up last month in the context of the Google
SOC
> > > > thread and the little discussion there was seemed favorable. So I
am
> > just
> > > > trying to revive the discussion to see if there were objections.
> > > >
> > > > See the following for the most recent discussion:
> > > >
> > > > http://svn.haxx.se/dev/archive-2006-04/0493.shtml
> > > >
> > > > I think this patch could benefit Subversion in general, but as I
> > pointed
> > > > out in the original message it is of particular importance to
tools
> > like
> > > > Subclipse we need to handle refactorings being performed by an IDE
in
> > a
> > > > seamless manner.
> > > >
> > > I've discussed this thing with lundblad and he said me to just
commit
> > > my patch. Before doing this I should create some tests for new
> > > behavior. But I haven't time for this now, will be good if you
extend
> > > my patch with tests, in this case I'll commit it immediately.
> >
> > Is the current patch attached to an issue # somewhere?
> I don't know any issue # about it. You can find patch in my original
> post: http://svn.haxx.se/dev/archive-2005-12/0020.shtml
>
> >
> > Are there particular scenarios that you think there ought to be tests
for?
> >
> I think basic copy & move of copied directories and files will be
enough.

Hi Ivan,

Your patch seems to work when moving/copying copied *files* only. Not
sure what exactly is going on, but trying to copy a copied directory
fails:

    svnadmin create /svn/repos/cm1

    svn co file:///svn/repos/cm1 /svn/wcs/cm1
    Checked out revision 0.

    touch /svn/wcs/cm1/foo

    svn mkdir /svn/wcs/cm1/bar
    A \SVN\WCS\cm1\bar

    svn add /svn/wcs/cm1/foo
    A \SVN\WCS\cm1\foo

    svn ci -m "log message" /svn/wcs/cm1
    Adding WCS\cm1\bar
    Adding WCS\cm1\foo
    Transmitting file data .
    Committed revision 1.

    svn cp /svn/wcs/cm1/foo /svn/wcs/cm1/foo1
    A \SVN\WCS\cm1\foo1

    svn cp /svn/wcs/cm1/foo1 /svn/wcs/cm1/foo2
    A \SVN\WCS\cm1\foo2

    svn cp /svn/wcs/cm1/bar /svn/wcs/cm1/bar1
    A \SVN\WCS\cm1\bar1

    svn cp /svn/wcs/cm1/bar1 /svn/wcs/cm1/bar2
 
c:\svn\svn.trunk.copymove\src-trunk.collabnet.trunk\subversion\libsvn_wc\adm_files.c:974:
(apr_err=155000)
    svn: URL 'file:///svn/repos/cm1/bar' doesn't match existing URL
'file:///svn/repos/cm1/bar1' in '/SVN/WCS/cm1/bar2/bar1'

I'll look into this tomorrow, but in the meantime if you have any thoughts
on what is wrong please let me know.

Thanks,

Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 16 22:52:35 2006

This is an archived mail posted to the Subversion Dev mailing list.