[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] expose svn_repos_replay via the RA API, Take 3

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-18 08:40:12 CET

On Thu, 17 Nov 2005, Garrett Rooney wrote:

> on along the path I was going down with the last patch. Here's the
> current state of things.
>
I had a quick look on the API and the ra_svn part:

> Index: subversion/include/svn_ra.h
> ===================================================================
> --- subversion/include/svn_ra.h (revision 17365)
> +++ subversion/include/svn_ra.h (working copy)
> @@ -1192,7 +1192,37 @@
> const char *path,
> apr_pool_t *pool);
>
> +
> /**
> + * Replay the changes from @a revision through @a editor and @a edit_baton.
> + *
> + * Changes will be limited to those that occur under @a base_dir, and if

Looking at the code, it seems that base_dir is an absolute path. Why
not make it relative to the URL of the session? Nearly everything else
is. (This might make the base_dir argument redundant, since you could
open the URL you want replayed).

> Index: subversion/libsvn_ra_svn/protocol
> ===================================================================
> --- subversion/libsvn_ra_svn/protocol (revision 17365)
> +++ subversion/libsvn_ra_svn/protocol (working copy)
> @@ -370,6 +370,13 @@
> params: ( path:string )
> response ( ( lock:lockdesc ... ) )
>
> + replay
> + params: ( revision:number base-path:string low-water-mark: number
> + send-deltas:bool )

low-water-mark should be optional in a tuple, like this:
[ low-water-mark:number ]

Sending -1 probably works, butit is not ow it is done elsewhere.

+1 for continuing on a branch.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 18 08:41:00 2005

This is an archived mail posted to the Subversion Dev mailing list.