Re: [PATCH] expose svn_repos_replay via the RA API, Take 3

On 11/17/05, Peter N. Lundblad <peter@famlundblad.se> wrote:

> Looking at the code, it seems that base_dir is an absolute path. Why
> not make it relative to the URL of the session? Nearly everything else
> is. (This might make the base_dir argument redundant, since you could
> open the URL you want replayed).

I like that idea... Dropping the argument at the RA layer and just
using the URL makes a lot of sense to me, thanks for the suggestion.

> > Index: subversion/libsvn_ra_svn/protocol
> > ===================================================================
> > --- subversion/libsvn_ra_svn/protocol (revision 17365)
> > +++ subversion/libsvn_ra_svn/protocol (working copy)
> > @@ -370,6 +370,13 @@
> > params: ( path:string )
> > response ( ( lock:lockdesc ... ) )
> >
> > + replay
> > + params: ( revision:number base-path:string low-water-mark: number
> > + send-deltas:bool )
>
> low-water-mark should be optional in a tuple, like this:
> [ low-water-mark:number ]
>
> Sending -1 probably works, butit is not ow it is done elsewhere.

Makes sense to me. Again, thanks for the review.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 18 19:02:33 2005