Re: Path canonicalization assertion failure triggered by add_dir_recursively()

Daniel Rall <dlr@collab.net> writes:

> svn_io_dir_read() is documented as a thin wrapper around
> apr_dir_read(). Two things:
>
> 1) There are other functions (e.g. svn_io_get_dirents2) which might be
> more appropriate here because they already filter out "." and "..".

Yup, it may be necessary to rev the svn_io_dir_read interface, for
behavioural rather than ABI reasons.

> 2) Should the semantics of svn_io_dir_read() change such that it
> always does path canonicalization?

If I was writing it from scratch it would return canonicalised paths,
I don't think we should not be using non-canonical paths within the
library.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org