Re: Path canonicalization assertion failure triggered by add_dir_recursively()

On Fri, 28 Oct 2005, Philip Martin wrote:

> Daniel Rall <dlr@collab.net> writes:
...
> > The error occurs because "." is passed to svn_wc_is_adm_dir(), which
> > eventually triggers the is_canonical() assertion failure in
> > svn_path_basename(). add_dir_recursive(), the caller of
> > svn_wc_is_adm_dir(), contains code which filters out empty, parent,
> > and "." paths, but that code isn't executed in time.
>
> "." isn't a canonical path. I think the error is that svn_io_dir_read
> should not be returning ".", it should convert it to "".

svn_io_dir_read() is documented as a thin wrapper around
apr_dir_read(). Two things:

1) There are other functions (e.g. svn_io_get_dirents2) which might be
more appropriate here because they already filter out "." and "..".

2) Should the semantics of svn_io_dir_read() change such that it
always does path canonicalization?

-- 
Daniel Rall
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org