Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'

Madan U Sreenivasan <madan@collab.net> writes:

> On Wed, 2005-10-05 at 02:56, Philip Martin wrote:
>> "Madan US" <madan@collab.net> writes:
>> >
>> > * subversion/libsvn_subr/path.c
>> > (svn_path_canonicalize): Modified to replace the trailing slash
>> > in the filename to @ if the last segment of the file path
>> > contained an @.

I think svn_path_canonicalize is the wrong place to be handling '@'
for peg revisions. All peg handling should happen in opt.c.

>> > * subversion/test/clients/cmdline/basic_tests.py
>> > (basic_peg_revision): Modified to check for the @ sign and the
>> > trailing slash combination.
>>
>> Your test doesn't really check your new code since it doesn't use an
>> '@' sign. You should probably write more complete tests, i.e. all
>> combinations, in test_canonical in tests/libsvn_subr/path-test.c.
> I think it does check the new code. It was run before(failure) and
> after(success) the changes... Pl. refer to the filename variable in
> basic_peg_revision() in basic_tests.py.

I was wrong.

> I did notice the change to tests/libsvn_subr/opt-test.c made for
> r15289. I couldnt figure out how it works.

It's fairly simple, it's just an array of inputs to, and expected
outputs from, svn_opt_parse_path.

> Am afraid I dont know much
> about tests/libsvn_subr/path-test.c either.
> Lemme read about it. In the meanwhile, if you could give me any
> pointers towards this, it would be great. thx.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org