[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 2318 : Inconsistent behavior with trailing '/'

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-10-05 08:43:07 CEST

On Wed, 2005-10-05 at 02:56, Philip Martin wrote:
> "Madan US" <madan@collab.net> writes:
>
> > Index: subversion/tests/clients/cmdline/basic_tests.py
> > ===================================================================
> > --- subversion/tests/clients/cmdline/basic_tests.py (revision 16440)
> > +++ subversion/tests/clients/cmdline/basic_tests.py (working copy)
> > @@ -1610,7 +1610,13 @@
> > output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> > 'cat', url+'@')
> >
> > + # With the trailing "/", expect success.
> > + output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> > + 'cat', wc_file+'/')
> > + output, errlines = svntest.actions.run_and_verify_svn(None, ["xyz\n"], [],
> > + 'cat', url+'/')
> >
> > +
> > #----------------------------------------------------------------------
> > ########################################################################
> >
> > Issue #2318: Inconsistent behavior with trailing '/'
> >
> > * subversion/libsvn_subr/path.c
> > (svn_path_canonicalize): Modified to replace the trailing slash
> > in the filename to @ if the last segment of the file path
> > contained an @.
> > * subversion/test/clients/cmdline/basic_tests.py
> > (basic_peg_revision): Modified to check for the @ sign and the
> > trailing slash combination.
>
> Your test doesn't really check your new code since it doesn't use an
> '@' sign. You should probably write more complete tests, i.e. all
> combinations, in test_canonical in tests/libsvn_subr/path-test.c.
  I think it does check the new code. It was run before(failure) and
after(success) the changes... Pl. refer to the filename variable in
basic_peg_revision() in basic_tests.py.

  I did notice the change to tests/libsvn_subr/opt-test.c made for
r15289. I couldnt figure out how it works. Am afraid I dont know much
about tests/libsvn_subr/path-test.c either.
  Lemme read about it. In the meanwhile, if you could give me any
pointers towards this, it would be great. thx.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 5 08:35:02 2005

This is an archived mail posted to the Subversion Dev mailing list.