Branko Čibej wrote:
>Branko Čibej wrote:
>
>
>
>>Branko Čibej wrote:
>>
>>
>>
>>
>>
>>>Erik Huelsmann wrote:
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>>I'm running make check now, but could someone verify that this fixes the
>>>>reported file handle leak?
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>This change of course doesn't plug the handle leak, because, there are a
>>>few "SVN_ERR" and "goto error" places before that could cause the file
>>>to remain open. I'm testing a different change right now.
>>>
>>>
>>>
>>>
>>>
>>>
>>There she is. With this change, translate-test passes on Windows. I'm
>>running the other tests now. This is all against HEAD of the 0.35.0
>>branch, by the way.
>>
>>[[[
>>Fix a handle leak that caused translate-test to fail on Windows because
>>an open file cannot be removed there.
>>
>>* subversion/libsvn_subr/subst.c (svn_subst_copy_and_translate): Use a
>> subpool to open all files and streams and destroy it to make sure
>> that all file handles are closed before returning.
>>]]]
>>
>>
>>
>>
>
>All ra_local tests pass on Windows with this patch. I'm testing ra_dav
>and ra_svn right now. If these tests pass, too (and I don't see any
>reason why they wouldn't), I'd like to include this patch in 0.35.0. I
>think the fact that it fixes a test failure is reason enough, and it's
>also minor enough to be safe.
>
>Votes, please?
>
>
All tests pass, BTW.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 18 03:23:47 2003