[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix Win32 file handle leak in translate-test.exe?

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-12-18 02:31:29 CET

On Wednesday 17 December 2003 20:10, Branko Čibej wrote:
> [snip]
> >[[[
> >Fix a handle leak that caused translate-test to fail on Windows because
> >an open file cannot be removed there.
> >
> >* subversion/libsvn_subr/subst.c (svn_subst_copy_and_translate): Use a
> > subpool to open all files and streams and destroy it to make sure
> > that all file handles are closed before returning.
> >]]]
>
> All ra_local tests pass on Windows with this patch. I'm testing ra_dav
> and ra_svn right now. If these tests pass, too (and I don't see any
> reason why they wouldn't), I'd like to include this patch in 0.35.0. I
> think the fact that it fixes a test failure is reason enough, and it's
> also minor enough to be safe.
>
> Votes, please?

+1.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 18 02:26:51 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.