[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

subversion-1.11.1/subversion/libsvn_client/upgrade.c:353: poor error checking ?

From: David Binderman <dcb314_at_hotmail.com>
Date: Sat, 12 Jan 2019 15:32:53 +0000

Hello there,

subversion-1.11.1/subversion/libsvn_client/upgrade.c:353] -> [subversion-1.11.1/subversion/libsvn_client/upgrade.c:358]: (style) The if condition is the same as the previous if condition

Source code is

      if (!err)
        externals_parent_url = svn_path_url_add_component2(
                                    externals_parent_repos_root_url,
                                    externals_parent_repos_relpath,
                                    iterpool);
      if (!err)

Maybe better code

      if (!err)
        externals_parent_url = svn_path_url_add_component2(
                                    externals_parent_repos_root_url,
                                    externals_parent_repos_relpath,
                                    iterpool);

      if (externals_parent_url)

Regards

David Binderman
Received on 2019-01-12 16:33:12 CET

This is an archived mail posted to the Subversion Users mailing list.