[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue with binaries generated(subversion 1.10.2) after compilation on AiX 7.2

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 27 Dec 2018 15:19:14 +0000

Daniel Shahaf wrote on Thu, Dec 27, 2018 at 15:04:09 +0000:
> In subversion/libsvn_subr/io.c, in svn_io_file_flush_to_disk(), there's
> an APR_STATUS_IS_EINVAL() check. Try making it check
> APR_STATUS_IS_EBADF() as well and handle it the same way (assuming "Bad
> file number" is strerror(3) of EBADF)

For clarity, I meant this:

[[[
Index: subversion/libsvn_subr/io.c
===================================================================
--- subversion/libsvn_subr/io.c (revision 1849781)
+++ subversion/libsvn_subr/io.c (working copy)
@@ -2505,6 +2505,10 @@ svn_error_t *svn_io_file_flush_to_disk(apr_file_t
          ignore the error. */
       if (rv == -1 && APR_STATUS_IS_EINVAL(apr_get_os_error()))
         return SVN_NO_ERROR;
+#ifdef _AIX
+ if (rv == -1 && APR_STATUS_IS_EBADF(apr_get_os_error()))
+ return SVN_NO_ERROR;
+#endif
 
       if (rv == -1)
         return svn_error_wrap_apr(apr_get_os_error(),
]]]

> --- read the comment there while
> you're at it. For context, creating new revisions relies on being able
> to flush the revision files to disk.
Received on 2018-12-27 16:19:26 CET

This is an archived mail posted to the Subversion Users mailing list.