On 30.11.2018 21:39, Nathan Hartman wrote:
> On Fri, Nov 30, 2018 at 4:56 AM Julian Foad <julianfoad_at_apache.org> wrote:
>
>> 钱海远(Nathan) wrote:
>>> We want to develop a feature like git pull request .
>> Some other companies are also interested in developing the same.
>>
>> There are a few different possible directions.
>>
>> You could implement pull requests (PR) using Subversion's branches. The PR
>> would be some kind of message that you send to your PR server, saying
>> something like, "please merge branch
>> $REPO_URL/branches/pull-requests/pr1234 to $REPO_URL/branches/my-branch".
>> The PR server would check out the target branch in to a WC local to that
>> server, attempt the merge, commit it, and delete the PR. If the merge
>> fails, the PR server can "svn delete" the PR branch; there is no way to
>> permanently delete the contents of that branch from history, but in many
>> cases that can be OK. If there are conflicts, the PR server can send an
>> error report back to the originating user.
>
> It seems to me that the refactorings and support for shelving/checkpointing
> being developed right now are putting into place a good foundation for
> implementing pull request type functionality as well.
I hope we're all aware that "pull request" is not a git feature, it's a
feature of some tools built on top of git, right? Just to keep things in
perspective. One could always build such tools with Subversion. The
workflow would be slightly different, but that really shouldn't be an issue.
-- Brane
Received on 2018-12-01 09:40:11 CET