[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Problems accessing GitHub's SVN-bridge with SVN 1.11

From: Thorsten Schöning <tschoening_at_am-soft.de>
Date: Sun, 4 Nov 2018 17:06:45 +0100

Guten Tag Thorsten Schöning,
am Sonntag, 4. November 2018 um 16:42 schrieben Sie:

> Others have the same problem and while it is true that GitHub might
> have implemented something on their own, it might help to have a look
> at the changes between 1.10 and 1.11 regarding the protocol.

Guess I found it:

> * Better error when http:// URL is not a Subversion repository (r1825302)

> /* Bail out early if we're not talking to a DAV server.
> Note that this check is only valid if we've received a success
> response; redirects and errors don't count. */
> if (opt_ctx->handler->sline.code >= 200
> && opt_ctx->handler->sline.code < 300
> && !opt_ctx->received_dav_header)
> {
> return svn_error_createf
> (SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
> _("The server at '%s' does not support the HTTP/DAV protocol"),
> session->session_url_str);
> }

"received_dav_header" is only set at one place, isn't that check
wrong? The code handles more than only DAV successfully from my point
of view:

> if (svn_cstring_casecmp(key, "dav") == 0)
> {
> /* Each header may contain multiple values, separated by commas, e.g.:
> DAV: version-control,checkout,working-resource
> DAV: merge,baseline,activity,version-controlled-collection
> DAV: http://subversion.tigris.org/xmlns/dav/svn/depth */
> apr_array_header_t *vals = svn_cstring_split(val, ",", TRUE,
> opt_ctx->pool);
>
> opt_ctx->received_dav_header = TRUE;
> [...]
> /* SVN-specific headers -- if present, server supports HTTP protocol v2 */
> else if (!svn_ctype_casecmp(key[0], 'S')
> && !svn_ctype_casecmp(key[1], 'V')
> && !svn_ctype_casecmp(key[2], 'N'))
> {

Mit freundlichen Grüßen,

Thorsten Schöning

-- 
Thorsten Schöning       E-Mail: Thorsten.Schoening_at_AM-SoFT.de
AM-SoFT IT-Systeme      http://www.AM-SoFT.de/
Telefon...........05151-  9468- 55
Fax...............05151-  9468- 88
Mobil..............0178-8 9468- 04
AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
Received on 2018-11-04 17:06:57 CET

This is an archived mail posted to the Subversion Users mailing list.