[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

fsfs 'structure' terminology: length/size v. size/expanded-size (was: Re: E130003: The XML response contains invalid XML - Follow-up)

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 16 Mar 2018 11:28:17 +0000

[ cc += dev@ ]

NOCERA, ANDY wrote on Thu, 15 Mar 2018 22:35 +0000:
> Folks,
> I used dump and load to debug the malformed node revision ID. Here are
> my steps and what learned. Looks like the revs' file text: entry has
> a zero instead of size.

To be clear, you mean the fourth field. On line 562 'size' is the name
of the fourth field but on line 119, and in the representation_t struct,
'size' is the name of the third field.[1]

This is a recipe for confusion. Normally I think of the fields using
the size/expanded-size terminology so I propose to change 'structure' to
use that terminology in lieu of length/size (and leave a note behind
pointing out that old versions of the document used <size> differently).



[1] All line numbers refer to subversion/libsvn_fs_fs/structure.

> diff db/revs/0/1 /usr/tmp/xrepox/db/revs/0/1
> 18c18
> < text: 1 76 48 0 ec69809945c46f2bb74e99a3ff7cd917
> ---
> > text: 1 76 48 48 ec69809945c46f2bb74e99a3ff7cd917
> 22c22
Received on 2018-03-16 12:28:29 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.