Re: post-commit hook

João M. S. Silva wrote on Tue, Dec 20, 2016 at 22:37:42 +0000:
> On 12/13/2016 06:09 AM, Daniel Shahaf wrote:
> >"smtp_use_ssl" is not a mailer.py configuration knob.
>
> You are right. I took that setting from a site:
>
> # added by jmss
> # http://sadomovalex.blogspot.pt/2009/12/use-gmail-smtp-server-for-post-commit.html
> smtp_use_ssl = true
>
> Previously, I could only send mails with that setting I took from the above
> blog. It may have become obsolete?

If it had become obsolete it wouldn't have been removed from the
mailer.py code to maintain backwards compatibility. More likely, that
parameter never existed in mailer.py as distributed by us. The comment
in that blog suggests it's a local patch by "asadomov".

(By the way, Postfix's main.cf configuration file happens to also have
a parameter named "smtp_use_ssl"; that knob is, however, entirely
unrelated to mailer.conf.)

> So, what is the correct/official way to solve this?

Make it possible for the configuration file to choose between SMTP_SSL()
or SMTP().

I won't be looking into that myself, but if you wish to do so, a patch
would be welcome: https://subversion.apache.org/patches

Cheers,

Daniel
Received on 2016-12-21 11:56:12 CET