On 21.10.2016 22:25, Bert Huijben wrote:
>
>> -----Original Message-----
>> From: Stefan Sperling [mailto:stsp_at_elego.de]
>> Sent: vrijdag 21 oktober 2016 14:14
>> To: yuan lixin <woodsp_at_126.com>
>> Cc: users_at_subversion.apache.org
>> Subject: Re: Re: subversion issue: ignore server invaild certificate in
> linux
>> On Fri, Oct 21, 2016 at 07:41:18PM +0800, yuan lixin wrote:
>>> but in the interface "svn_auth_ssl_server_trust_prompt_func_t",
>>> the actual parameter is "failures", not "*failures". so it can not
> change
>>> the svn's failures in linux, then can not ignore certificate.
>>> could you look at my code for a solution.
>>>
>>> Thank you
>>> --woodsp
>> libsvn_subr gets 'failures' from the 'parameters' hash:
> Code shouldn't touch the failures value; they should change the
> accepted_failures in the credentials value.
>
> /** @c SVN_AUTH_CRED_SSL_SERVER_TRUST credentials. */
> typedef struct svn_auth_cred_ssl_server_trust_t
> {
> /** Indicates if the credentials may be saved (to disk). For example, a
> * GUI prompt implementation with a checkbox to accept the certificate
> * permanently shall set @a may_save to TRUE if the checkbox is checked.
> */
> svn_boolean_t may_save;
> /** Bit mask of the accepted failures */
> apr_uint32_t accepted_failures;
> } svn_auth_cred_ssl_server_trust_t;
>
>
> If svn uses a different way to change a value in the caller that is a bug
> that should be fixed there.
It does not; we do the right thing, see my other post.
-- Brane
Received on 2016-10-22 04:04:47 CEST