[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Access denied error on checkout-commit after updating to 1.9.X

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Tue, 8 Sep 2015 13:37:14 +0300

On 8 September 2015 at 13:12, Branko Čibej <brane_at_wandisco.com> wrote:
> On 07.09.2015 18:42, Ivan Zhakov wrote:
>> We developed patch that converts all ERROR_ACCESS_DENIED errors from
>> SetFileInformationByHandle() to SVN_ERR_UNSUPPORTED_FEATURE and
>> fallbacks to normal close + rename() (see attached file), but I'm not
>> sure it's the best solution and going to investigate this problem
>> tomorrow.
>
> Ideally, there'd be a way to check if the 'access denied' error is real,
> or just a side effect of SMBv1. But I can't think of a reasonable way to
> do this without (probably) incurring an unacceptable slowdown in the WC.
>
Agree. But I think r1701736 approach is acceptable, given that
RenameByHandle code is performance optimization and 'access denied'
error only happens when we retry rename after finding that target
directory doesn't exists. So generally we don't get these access
denied errors.

-- 
Ivan Zhakov
Received on 2015-09-08 12:37:43 CEST

This is an archived mail posted to the Subversion Users mailing list.