Re: [BUG] svnlook diff infinite loop

> On Fri, May 30, 2014 at 5:36 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>>
>> Hi,
>>
>>
>>
>> I tried to reproduce your problem for debugging.
>>
>>
>>
>> I did a:
>>
>>
>>
>> $ svn –version
>>
>> svn, version 1.8.9-SlikSvn-1.8.9-X64 (SlikSvn/1.8.9) X64
>>
>> compiled May 8 2014, 20:00:31 on x86_64-microsoft-windows6.2.9200
>>
>> <snip>
>>
>> $ svnadmin create svnlook-loop
>>
>>
>>
>> $ svnadmin load svnlook-loop < svnlook_diff_infinite_loop.dump
>>
>>
>>
>> <<< Started new transaction, based on original revision 1
>>
>> * adding path : xyz ... done.
>>
>>
>>
>> ------- Committed revision 1 >>>
>>
>>
>>
>> <<< Started new transaction, based on original revision 2
>>
>> * editing path : xyz ... done.
>>
>>
>>
>> ------- Committed revision 2 >>>
>>
>>
>>
>> <<< Started new transaction, based on original revision 3
>>
>> * editing path : xyz ... done.
>>
>>
>>
>> ------- Committed revision 3 >>>
>>
>>
>>
>> $ svnlook diff svnlook-loop
>>
>> Index: xyz
>>
>> ===================================================================
>>
>> --- xyz 2014-05-29 13:37:20 UTC (rev 2)
>>
>> +++ xyz 2014-05-29 13:37:32 UTC (rev 3)
>>
>>
>>
>> Property changes on: xyz
>>
>> ___________________________________________________________________
>>
>> Modified: svn:mergeinfo
>>
>> ## -1,3 +1,3 ##
>>
>> /abc/2.0.A:8
>>
>> /abc/2.1:6
>>
>> -/abc/2.2:7
>>
>> \ No newline at end of property
>>
>> +/abc/2.2:7,9
>>
>> \ No newline at end of property
>>
>>
>>
>>
>>
>> Can you explain what is different for you than in this scenario, as this
>> certainly doesn’t reproduce your problem
>>
>>
>>
>> Bert
>>
>>
>>
>> From: Arwin Arni Nandagopal [mailto:arwin_at_collab.net]
>> Sent: donderdag 29 mei 2014 15:59
>> To: users_at_svn
>> Subject: [BUG] svnlook diff infinite loop
>>
>>
>>
>> svnlook diff hangs on an infinite loop when it encounters certain
>> svn:mergeinfo.
>>
>>
>>
>> This happens ONLY on Windows 64-bit svn 1.8.x or later client.
>>
>>
>>
>> I was able to trace the flow of code all the way to:
>>
>>
>>
>> subversion/svnlook/svnlook.c:display_prop_diffs
>>
>>
>>
>> Inside here, there is a call to:
>>
>> subversion/libsvn_diff/util.c:svn_diff__display_prop_diffs
>>
>>
>>
>> Which doesn't seem to get executed at all.
>>
>>
>>
>> I have no experience debugging C code on Windows, and hence the
>> speculation.
>>
>>
>>
>> I have with me the smallest possible subset of data that will reproduce
>> this issue.
>>
>> Load the attached dumpfile and run svnlook diff -r3 /path/to/repo with a
>> 1.8.x or later binary on a Windows 64-bit machine, and it WILL hang.
>>
>>
>>
>> I really hope someone with debugging skills on Windows can help me out
>> here.
>>
>>
>> Regards,
>>
>> Arwin Arni
>
>On Thu, Jun 5, 2014 at 9:04 AM, Arwin Arni Nandagopal <arwin_at_collab.net> wrote:
> Hi Bert,
>
> Sorry for the delayed reply. I'm not sure if SlikSvn will suffer from the
> same problem. I'm not even sure where the problem lies. I am able to
> reproduce this issue with the open source command-line client. Does SlikSvn
> customize the client in any way (possibly removing the issue)? I installed
> SlikSvn 1.8.9 x64 and I wasn't able to reproduce the error either. Where I
> am getting the error is the following environment:
>
> $ svn --version
> svn, version 1.8.9 (r1591380)
> compiled May 8 2014, 05:13:23 on x86_64/x86-microsoft-windows5.1.2600
>

What do you mean with "the open source command-line client"? Where did
you download this client? The Apache Subversion project itself does
not produce binaries.

Or did you compile the client yourself from source?

[ BTW: this list prefers bottom-posting ... i.e. please put your reply
at the bottom or inline, thanks. ]

-- 
Johan