RE: Cancelling location segments operation from callback
From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 26 Jan 2014 12:48:18 +0100
We use this pattern quite a few times in our own Subversion code (usually using the specially invented SVN_ERR_CEASE_INVOCATION code to document this pattern), so there is not really something wrong with this pattern.
The problem is that the our implementation of the serf library in <= 1.8.x doesn’t handle these errors properly and doesn’t stop the request’s handling when cancelling. So when you start using the serf ra session again the previous request continues, and you usually get the same error again and again. (This is the result of how serf works)
This specific problem is fixed in the ra_serf error handling cleanup that is targeted towards releasing in 1.9.
From: Branko Čibej [mailto:brane_at_wandisco.com]
On 26.01.2014 04:23, Martin Panter wrote:
This is a followup from my message from a couple months ago:
No, callbacks should only return errors if something is wrong. The only correct way to cancel an operation in Subversion is to set the flag that the cancellation callback uses.
-- Branko Čibej | Director of Subversion WANdisco // Non-Stop Data e. brane_at_wandisco.com <mailto:brane_at_wandisco.com>Received on 2014-01-26 12:49:18 CET
This is an archived mail posted to the Subversion Users mailing list.