[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: vc-svn.el for emacs 21 and single .svn directory

From: Tobias Bading <tbading_at_web.de>
Date: Sat, 20 Jul 2013 17:08:12 +0200

On 20.07.2013, at 01:18, Karl Berry wrote:
> The vc-svn.el file at
> http://svn.apache.org/repos/asf/subversion/trunk/contrib/client-side/emacs/vc-svn.el
> for svn support in Emacs 21 broke with the change in Subversion that
> puts .svn only at the top level of a repository. Now the
> (vc-svn-registered) test for whether a file is in a Subversion
> repository always fails, leading Emacs to report that nothing in svn is
> "under version control".
>
> I made the following trivial change to have that function merely call
> svn status, omitting the efficiency check for .svn/entries, and it has
> been working ok.
>
> Not sure if vc-svn.el is maintained here or if anyone besides me on the
> planet is still using Emacs 21, but thought I'd pass it along. If it's
> deemed worth submitting as an issue, I'm happy to do that.
>
> Best,
> Karl
>
> --- ORIG/vc-svn.el 2013-07-19 16:03:05.740311730 -0700
> +++ vc-svn.el 2013-07-19 16:12:16.241234191 -0700
> @@ -127,6 +127,5 @@
> "Return true if FILE is registered under Subversion."
> - ;; First, a quick false positive test: is there a `.svn/entries' file?
> - (and (file-exists-p (expand-file-name ".svn/entries"
> - (file-name-directory file)))
> - (not (null (vc-svn-run-status file)))))
> + (not (null (vc-svn-run-status file))))
> + ;; We used to check for .svn/entries here for efficiency,
> + ;; but now .svn is only at the top level of the repository.
>
> Diff finished at Fri Jul 19 16:12:17

Hello Berry,

according to the history of lisp/vc/vc-svn.el in the GNU Emacs 24 Bazaar branch (http://bzr.savannah.gnu.org/r/emacs/emacs-24), a first version of that file was committed on 2003-05-05. In r103228 on 2011-02-11, support for Subversion 1.7's new only-one-.svn-dir working copy format was implemented. The current GNU Emacs version 24.3 has no problems dealing with Subversion 1.7 or 1.8 working copies right out of the box :-).

You're probably not the last person on the planet using Emacs 21... yet. Come over to the 24-side... we have cookies! :-D

Have a nice weekend,
Tobias
Received on 2013-07-20 17:08:53 CEST

This is an archived mail posted to the Subversion Users mailing list.