On Mon, Oct 15, 2012 at 7:21 AM, Jason Heeris <jason.heeris_at_gmail.com> wrote:
> On 15 October 2012 18:53, Nico Kadel-Garcia <nkadel_at_gmail.com> wrote:
>> So why do you do it? Similar to putting spaces and question marks and
>> quotation marks in file names, it can cause a lot of scripting
>> confusion for your hook scripts.
>
> I did it once, because I didn't realise it would cause problems, and
> it continues to bite me today.
>
> To be fair - SVN can handle all sorts of non-ASCII characters, spaces,
> etc. so I didn't think that punctuation would be problematic. They're
> valid on any filesystem in current use, and I write hook scripts in
> Python, so string processing doesn't fall over with odd characters.
Understandable, but it can really bite the next person who works with
your scripts or material. I've encountered a lot of adventures with
non-7-bit-ASCII character sets over the years, and it leads to me
doing a lot of sanitizing of filenames in hook scripts: usually, I
prefer to simply reject such filenames in the pre-commit script.
Received on 2012-10-15 14:06:13 CEST