Re: Square brackets in file names and authz (in VisualSVN 2.5.5)

On Thu, Jul 12, 2012 at 6:59 AM, Jason Heeris <jason.heeris_at_gmail.com> wrote:
> On 12 July 2012 08:03, Jason Heeris <jason.heeris_at_gmail.com> wrote:
>>
>> I'll file it later today and see what response I get.
>
>
> Apparently I need a buddy with whom to file the bug. If anyone would be
> willing, I'd appreciate it.
>
> I've attached a bash script that reproduces the problem under SVN 1.7.4.
> Please read the script before running it, I make no assurances that it's not
> accidentally going to do something awful...

Thanks for the thoroughness, writing a reproduction script etc. Please
go ahead and file an issue in the issue tracker.

I've taken a quick look in the source code: the problem is the config
parsing code, which parses the "repos:path" thing as a section name
(everything between the square brackets in de config file). See the
function parse_section_name in libsvn_subr/config_file.c [1].

I think the only character that causes problems is ']' (which ends the
section name parsing). It seems not too hard to change that parsing
function to make it handle some kind of escape sequence for ']'
(perhaps ']]'). Would you care to write a patch [2]?

[1] http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/config_file.c?view=markup
    from line 315 onward (the comment says "Read chars until enounter ']' ...").
[2] http://subversion.apache.org/docs/community-guide/general.html#patches

-- 
Johan