On Wed, Jun 20, 2012 at 6:16 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Tue, Jun 19, 2012 at 01:39:48PM -0400, Daniel Richard G. wrote:
>> host:/tmp/subversion$ ./get-deps.sh
>> [script output elided]
>>
>> host:/tmp/subversion$ find . -name apr_hash.c
>> ./apr/tables/apr_hash.c
>>
>> host:/tmp/subversion$ ./get-deps.sh
>> [script output elided]
>>
>> host:/tmp/subversion$ find . -name apr_hash.c
>> ./apr/apr-1.4.6/tables/apr_hash.c
>> ./apr/tables/apr_hash.c
>>
>>
>> Re-running the script may be necessary in case some packages failed to
>> download the first time around (zlib in my case, as the current version
>> is now 1.2.7 instead of 1.2.6).
>>
>> A proposed patch against SVN is attached. (It also bumps the zlib
>> version, as that is needed anyway.)
>>
>>
>> --Daniel
>>
>> (Please Cc: any replies to me, as I am not subscribed to this list.)
>
> Thanks! Committed as two separate patches -- zlib bump in r1352031,
> idempotency fix in r1352032.
>
> In the future, please send patches to dev@, and more importantly provide
> a log message for each patch you send, as described here:
> http://subversion.apache.org/docs/community-guide/general.html#patches
Is it worth teaching get-deps.sh to download to a temporary file, and
only put it in place when the download is complete? Or to run a test
"unzip -l" or "tar tf -" on downloads to verify them before
proceeding? Partial, interrupted downloads are a real pain in the bum.
Received on 2012-06-20 14:06:59 CEST