On Sun, Jan 22, 2012 at 2:32 PM, Jakub Adam <jakub.adam_at_ktknet.cz> wrote:
> Hi Mark,
>
>> On Fri, Jan 20, 2012 at 9:17 AM, Laurent Bigonville<bigon_at_debian.org>
>> wrote:
>>
>>> Could you please considere adding OSGi information to the java
>>> binding.
>>>
>>> These meta informations seems to be required to be able to built
>>> eclipse completely from the source.
>>
>>
>> I maintain Subclipse and contribute to the maintenance of JavaHL in
>> Subversion. I do not really have any objections to the concept but it
>> would be helpful to have a patch created as a patch to Subversion
>> itself and the trunk version. It looks like the patch in the link is
>> to the Debian-specific packaging (and for an older version of SVN).
>
>
> I'm the original author of Debian packaging of Subclipse. As you requested,
> here is attached a patch against Subversion trunk. Also I improved it a bit
> so that Bundle-Version attribute in manifest is correctly set during build.
>
> It would be nice if this can be also commited to 1.6.x and 1.7.x branches if
> they are still supported (Debian now packages versions from 1.6). As far as
> I tested, the patch should apply without problems.
>
>
>> The link also says this:
>>
>> "This jar is a dependency of eclipse-subclipse package. Attached patch
>> adds the needed metadata."
>>
>> I have no idea what Debian might be doing in its own packaging but in
>> Subclipse itself this is not true. Subclipse does not use the
>> svn-javahl.jar file from Subversion. The JavaHL API is wrapped in an
>> Eclipse plugin that Subclipse itself provides and this plugin of
>> course has all of the OSGI information included since it is a plugin.
>
>
> I'm aware of that, but in Debian we prefer to reuse already packaged
> libraries
> rather than bundle their code with applications, so Subclipse is patched to
> depend on external javahl jar. I think the change we are requesting here
> doesn't have any impact on the way Subclipse upstream uses javaHL, so you
> can
> still bundle it inside the plugin if you like.
>
> Thanks for your cooperation.
I made some tweaks but have committed the patch. See:
http://svn.apache.org/viewvc?view=revision&revision=1234864
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2012-01-23 17:05:25 CET