[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TortoiseSVN exception dialog improvements?

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 17 Oct 2011 21:27:44 +0200

On 17.10.2011 19:46, Mark Phippard wrote:
> I wonder if the TortoiseSVN team could create a link to a Google
> search for the error code on the dialog where they ask the user to
> report the problem? It could ask them to check that link first for
> other reports of the same problem.
> That might cut down on the list spam and also get the user an answer faster.

I've already removed the email address of the users group from the error
message, only the link to the web page for the mailing list is still there.

As you may recall, I've always been opposed to the assert statements. I
prefer clear error messages and a proper cleanup of resources,
especially if there _is_ a chance to do so. Maybe now you guys
understand why.

> Alternatively, maybe we could add some kind of error code lookup URL
> on our site? Something like:
> http://subversion.apache.org/errorcode/E235000
> TortoiseSVN could link user to this URL and our page could direct the
> user to a wiki page for known errors or a Google search otherwise?
> When an error becomes really common we could add a wiki page for that
> code, otherwise just do a search.
> Just some thoughts.

Since I was repeatedly told that assert statements are only used if
there's no chance to return an error and clean up the resources, I can't
use a custom dialog in that case but must rely on the windows own
message box. Because that's the only dialog that's guaranteed to work
even in situations where stack and heap are corrupted.
And that means no clickable links, no buttons to start a browser, ...

However if assert statements are used in other situations as well, I
suggest to return proper error messages instead.

I could implement opening a browser to a custom search page with that
error message, but not for asserts.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2011-10-17 21:28:21 CEST

This is an archived mail posted to the Subversion Users mailing list.