Re: svnsync UTF8 problem

I had no intention of filing a bug until I had done as much debugging as
possible, not being a developer myself. Thank you for your advice about
where to look for the error in the source code. I can see that the error is
thrown in the 'svn_repos_validate_prop' function in the file you mentioned.
Specifically, the line is 182:

/* Validate "svn:" properties. */ 176 if (svn_prop_is_svn_prop(name) &&
value != NULL) 177 { 178 /* Validate that translated props (e.g., svn:log)
are UTF-8 with 179 * LF line endings. */ 180 if
(svn_prop_needs_translation(name)) 181 { 182 if
(svn_utf__is_valid(value->data, value->len) == FALSE) 183 { 184 return
svn_error_createf 185 (SVN_ERR_BAD_PROPERTY_VALUE, NULL, 186 _("Cannot
accept '%s' property because it is not encoded in " 187 "UTF-8"), name);
188 }
So, it seems that the "svn_utf_is_valid" function is the one that is
rejecting this value. Would you happen to know where this function is
defined?

Thank you

-- 
Srdan Dukic
On 11 October 2011 09:08, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Don't and don't.
>
> If you want to see what values cross the network, go to the validation
> function in libsvn_repos/fs-wrap.c that generates the error message you
> get.
>
> And I _am_ a developer, and I already asked you not to file a bug.
> Please don't until you have identified a problem we don't already know
> about.  Thanks.
>
> Srdan Dukic wrote on Tue, Oct 11, 2011 at 08:59:38 +1300:
> > Thank you for your help. I'll try and turn on debugging on the dav_svn
> > module to see what actual values are being passed across the network and
> if
> > that doesn't turn up anything, I guess I'll just ask on the dev mailing
> list
> > or open a bug.
> >
> > Thanks again
> > --
> > Srdan Dukic
> >
> > On 11 October 2011 08:40, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> >
> > > Your revprops values are all ASCII and LF linefeeds, so r6107 should
> > > get committed to the mirror without issue.  The --source-prop-encoding
> > > is new in 1.7.
> > >
> > > So, yes, if you're still seeing the error *while syncing r6107* (i.e.,
> > > mirror HEAD is r6106), I'm not really sure what's going on.
> > >
> > > Srdan Dukic wrote on Tue, Oct 11, 2011 at 08:29:04 +1300:
> > > > > Odd.  Perhaps some other revision property of that revision
> contains
> > > > > non-UTF-8?
> > > > >
> > > >
> > > > The other revision properties are:
> > > >
> > > > # svn proplist --revprop -r 6107 http://subversion/project/Flow
> > > > Unversioned properties on revision 6107:
> > > >   svn:log
> > > >   svn:author
> > > >   svn:date
> > > >
> > > >
> > > > > > > The actual value of the svn:log property is:
> > > > > > >
> > > > > > > "When printing a form through the full task list the client's
> TEF
> > > > > number
> > > > > > > has <B> and </B> beside it (for cds)."
> > > > > > >
> > > > > > > Which doesn't have any characters that should need any UTF8
> > > handling.
> > > > > > >
> > > > >
> > > > > svn propget --revprop -rN --strict svn:log | xxd
> > > > >
> > > >
> > > > When I look at the contents of the properties, they all seem to be in
> > > > regular ASCII:
> > > >
> > > > # svn propget --revprop -r 6107 --strict svn:author
> > > > http://subversion/project/Flow | xxd
> > > > 0000000: 5869 6e67                                Xing
> > > >
> > > > # svn propget --revprop -r 6107 --strict svn:date
> > > > http://subversion/project/Flow | xxd
> > > > 0000000: 3230 3034 2d30 342d 3238 5430 313a 3331  2004-04-28T01:31
> > > > 0000010: 3a34 302e 3030 3030 3030 5a              :40.000000Z
> > > >
> > > > # svn propget --revprop -r 6107 --strict svn:log
> > > > http://subversion/project/Flow | xxd
> > > > 0000000: 5768 656e 2070 7269 6e74 696e 6720 6120  When printing a
> > > > 0000010: 666f 726d 2074 6872 6f75 6768 2074 6865  form through the
> > > > 0000020: 2066 756c 6c20 7461 736b 206c 6973 7420   full task list
> > > > 0000030: 7468 6520 636c 6965 6e74 2773 204e 4849  the client's NHI
> > > > 0000040: 206e 756d 6265 7220 6861 7320 3c42 3e20   number has <B>
> > > > 0000050: 616e 6420 3c2f 423e 2062 6573 6964 6520  and </B> beside
> > > > 0000060: 6974 2028 666f 7220 6364 7329 2e         it (for cds).
> > > >
> > > > > > Has anyone else had this problem? If so, how did you solve it?
> > > > > > >
> > > > >
> > > > > svnsync sync --source-prop-encoding
> > > > >
> > > > >
> > > > Is this a valid option to pass to svnsync? When I attempt to run
> svnsync
> > > > with this option, I get the following error:
> > > >
> > > > svnsync: invalid option: --source-prop-encoding
> > > >
> > > > The only other thing I can think of is that the original commit may
> have
> > > > been done on a windows machine where the locale was set to some
> > > non-english
> > > > value, but even then, the properties seem to all be in plain ASCII
> > > >
> > > > Thank you
> > > > --
> > > > Srdan Dukic
> > >
>