[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: 1.7.0-alpha1 feedback (Issue #3933)

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 21 Jun 2011 12:30:48 +0200

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: dinsdag 21 juni 2011 10:31
> To: Daniel Shahaf
> Cc: users_at_subversion.apache.org; Uwe Schuster
> Subject: Re: 1.7.0-alpha1 feedback
>
> On Tue, Jun 21, 2011 at 10:51:08AM +0300, Daniel Shahaf wrote:
> > FWIW it's not just a problem with (explicit) port specifications, there
> > is a similar issue when an external definition uses https://svn.a.o and
> > my checkout URL uses https://svn.eu.a.o.
> >
> > The 'same repos' checks could use UUID rather than URL.
>
> Yeah, looking at the URL is not right. (See my last comment to the issue.)

That depends on where you look at it.

This error is raised in the ra layer (Inside svn_ra_reparent) where you have
a connection to a single repository via its url: In that location it should
fail on every url not pointing to exactly the same repository.

I think this issue is caused by the ra_serf code that removes default port
numbers when you connect to a repository by using APR. Neon used its own
rules so it wouldn't fail.

But with our strict rules that any uri passed to our apis must be canonical,
we shouldn't see this problem.

But as I found out (and fixed in r1137927) our uri canonicalization for user
provided uris didn't check port numbers at all.

        Bert
Received on 2011-06-21 12:31:21 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.