[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Is rep-sharing enabled by default?

From: Nick Stolwijk <nick.stolwijk_at_gmail.com>
Date: Tue, 24 May 2011 14:23:13 +0200

My mistake. I mostly use the man pages. ;) At least I was correct
about the # as comment lines.

With regards,

Nick Stolwijk
~Senior Java Developer~

iPROFS
Wagenweg 208
2012 NM Haarlem
T +31 23 547 6369
F +31 23 547 6370
I www.iprofs.nl

On Tue, May 24, 2011 at 2:19 PM, Nico Kadel-Garcia <nkadel_at_gmail.com> wrote:
> On Tue, May 24, 2011 at 7:18 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> On Tue, May 24, 2011 at 01:00:45PM +0200, Nick Stolwijk wrote:
>>> In all Unix like configuration files, the # means that line is a
>>> comment. Often the value mentioned on the line is not the default, so
>>> uncommenting the line will give you the other value.
>
> Stefan, Nick is mistaken about this. Review any number of common tools
> like Sendmail, Bind, and OpenSSH, Makefile for thousands of GNU
> projects, etc. Nick, you're going to have real trouble if you rely on
> this as expected practice. The "common practice" in the Free Software
> Foundation (maintainers of gcc and emacs and gzip), for example, is
> precisely the reverse. *Defaults* are commented out, and uncommenting
> them does *nothing*. Uncommenting and editing them changes things.
>
>> I just committed the following change to clear this up once and for all
>> in newly generated configuration files.
>>
>> ------------------------------------------------------------------------
>> r1126980 | stsp | 2011-05-24 13:16:36 +0200 (Tue, 24 May 2011) | 4 lines
>>
>> * subversion/libsvn_fs_fs/fs_fs.c
>>  (write_config): Be crystal-clear about the default value of the rep-sharing
>>   option.
>>
>>
>> Index: subversion/libsvn_fs_fs/fs_fs.c
>> ===================================================================
>> --- subversion/libsvn_fs_fs/fs_fs.c     (revision 1126979)
>> +++ subversion/libsvn_fs_fs/fs_fs.c     (revision 1126980)
>> @@ -1150,6 +1150,7 @@ write_config(svn_fs_t *fs,
>>  "### The following parameter enables rep-sharing in the repository.  It can" NL
>>  "### be switched on and off at will, but for best space-saving results"      NL
>>  "### should be enabled consistently over the life of the repository."        NL
>> +"### rep-sharing is enabled by default."                                     NL
>>  "# " CONFIG_OPTION_ENABLE_REP_SHARING " = true"                              NL
>
> But being crystal clear is always a good idea.
>
Received on 2011-05-24 14:23:42 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.