[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)

From: David Dyer-Bennet <dd-b_at_dd-b.net>
Date: Mon, 6 Dec 2010 13:44:23 -0600

Subversion 1.6.12 running on Centos 5.5

If the value of the environment variable VISUAL contains a space,
subversion fails when attempting to invoke the editor to get the
comment.

sh-3.2$ export VISUAL="/home/spaces in name/bin/emacs"
sh-3.2$ svn commit
sh: /home/spaces: No such file or directory
svn: Commit failed (details follow):
svn: system('/home/spaces in name/bin/emacs svn-commit.tmp') returned 32512

As you see in the error, it's constructing a command string without
consideration of the possibility of spaces in various places.

This also occurs when running subvrsion under Cygwin on Windows XP. I
discovered it there, because there the natural place to put my
personal editor script (which attaches to an existing emacs if there
is one, and otherwise starts emacs itself, with various other personal
parameters and condition checking) ends up having the path

    /cygdrive/c/Documents and Settings/david.bennet/My Documents/bin/ew

which has three spaces in two path components, neither name chosen by
me.

The workaround, obviously, is to place your editor (or editor script)
in a place that doesn't have spaces in the path.

So, can somebody confirm this please? And, ideally, submit the bug
(since I keep getting stuck trying to go through all the hoops they
want you to go through to become enabled to do that)?

-- 
David Dyer-Bennet, dd-b@dd-b.net; http://dd-b.net/
Snapshots: http://dd-b.net/dd-b/SnapshotAlbum/data/
Photos: http://dd-b.net/photography/gallery/
Dragaera: http://dragaera.info
Received on 2010-12-06 20:46:15 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.