[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oh, shoot: Issue 2591 should not have been closed

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 25 Jun 2010 16:12:15 +0300 (Jerusalem Daylight Time)

This came across as a very negative tone. (I assume you had read the
comments in the issue)

It's nominated for backport. There was a dev@ thread asking if it should
get some (fairly trivial to implement) changes before being backported.
The thread concluded, but the branches/1.6.x/STATUS entry is still marked
"waiting for thread to resolve".

If you'd like to move this forward, you can ask on dev@ to see what
changes need to be made (if any) and for more +1 votes (and less -0 votes)

Regarding your shell script, please review the regression test in HEAD of
trunk to ensure it captures the desired behaviour.


Nico Kadel-Garcia wrote on Fri, 25 Jun 2010 at 15:08 -0000:
> Good morning:
> This is Nico Kadel-Garcia, the person who submitted the svnadmin
> hotcopy/symlink issue number 2591 in 2006. I see that it's been very
> recently marked "resolved". This is not fixed in the recent 1.6.12
> release, I'm sad to say.
> This bug has been a pain in my backside for 4 years. Can we seriously
> encourage its inclusion in 1.6.13, at least?
> I've also included a somewhat more robust test script below, to verify
> that the symlinks are duplicated and they point to the same place.
> ========================================
> #!/bin/sh
> #
> # test-hotcopy-hardlink.sh - verify svnadmin hotcopy preservation of symlinks
> REPO1=/tmp/repo1
> REPO2=/tmp/repo2
> rm -rf $REPO1 $REPO2 || exit 1
> svnadmin create $REPO1
> /bin/mv $REPO1/conf/passwd $REPO1/conf/passwd.template
> ln -s $REPO1/conf/passwd.template $REPO1/conf/passwd
> svnadmin hotcopy $REPO1 $REPO2
> readlink $REPO1/conf/passwd
> if [ ! -h $REPO2/conf/passwd ]; then
> echo "Error: svnadmin hotcopy fails to duplicate symlinks in repository"
> exit 1
> elif [ "`readlink $REPO1/conf/passwd`" != "`readlink
> $REPO2/conf/passwd`" ]; then
> echo "Error: svnadmin hotcopy gets symlinks wrong in repository"
> exit 1
> fi
Received on 2010-06-25 15:12:01 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.