On Sat, Feb 27, 2010 at 3:25 AM, Alexey Neyman <stilor_at_att.net> wrote:
> Hi all,
>
> It seems that I encountered a bug in 'svnlook pl --revprop': it fails with
> the following message:
>
> $ svnlook pl --revprop -t 10547-86b /svn/test-svn
> svnlook: Invalid revision number '-1'
Reproducible with trunk_at_911289.
>
> Observed with Subversion 1.6.6. Looks like offending code is this block in
> do_plist():
>
> ==============================
> if (path != NULL)
> ...
> else
> {
> SVN_ERR(svn_fs_revision_proplist(&props, c->fs, c->rev_id, pool));
> revprop = TRUE;
> }
> ==============================
>
> Note that it always uses svn_fs_revision_proplist(), even when '-t TXN' is
> passed. In this case, c->rev_id == SVN_INVALID_REVNUM (-1), and
> svn_fs_revision_proplist() rightfully fails.
>
> Shouldn't it be using svn_fs_txn_proplist() instead, just as
> get_property() chooses between svn_fs_txn_prop() and
> svn_fs_revision_prop()?
Think so. Do you want to submit a patch to fix this issue?
Lieven
Received on 2010-02-27 20:36:19 CET