[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

"svnlook pl --revprop" does not work on transactions?

From: Alexey Neyman <stilor_at_att.net>
Date: Fri, 26 Feb 2010 22:15:12 -0800

Hi all,

It seems that I encountered a bug in 'svnlook pl --revprop': it fails with
the following message:

$ svnlook pl --revprop -t 10547-86b /svn/test-svn
svnlook: Invalid revision number '-1'

Observed with Subversion 1.6.6. Looks like offending code is this block in

  if (path != NULL)
      SVN_ERR(svn_fs_revision_proplist(&props, c->fs, c->rev_id, pool));
      revprop = TRUE;

Note that it always uses svn_fs_revision_proplist(), even when '-t TXN' is
passed. In this case, c->rev_id == SVN_INVALID_REVNUM (-1), and
svn_fs_revision_proplist() rightfully fails.

Shouldn't it be using svn_fs_txn_proplist() instead, just as
get_property() chooses between svn_fs_txn_prop() and

This conditional is still in /trunk, so most likely, bug is also
reproducible with top-of-trunk Subversion.

Received on 2010-02-27 07:15:49 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.